catalog icon indicating copy to clipboard operation
catalog copied to clipboard

Return status code 404 when Page Not Found

Open kyleoliveiro opened this issue 6 years ago • 2 comments

Currently, a status code of 200 is returned regardless of whether the requested page exists or not. Ideally, the status code should be 404.

kyleoliveiro avatar Jun 07 '18 09:06 kyleoliveiro

Can you elaborate on the scenario where this doesn't work? Maybe provide a minimal reproducible setup?

Note that this probably only is the case during development (i.e. when using catalog start). Once built, Catalog isn't responsible for serving your pages.

jstcki avatar Jul 12 '18 07:07 jstcki

Yes, it's during development. I'm using Cypress to check for pages which should exist in the documentation by visiting a URL and asserting that the response code is 200.

kyleoliveiro avatar Jul 12 '18 11:07 kyleoliveiro