Tim Ramlot

Results 302 comments of Tim Ramlot

> Thanks @inteon , nice work! > > It seems you have removed the `Stop()` from Controller, so how should users stop one or more specific controller? @FillZpp what do...

@vincepri are these breaking changes ok?: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_controller-runtime/2159/pull-controller-runtime-apidiff-master/1625461909174095872

I updated the PR and removed the dynamic `Controller` shutdown, now there is only dynamic `Source` shutdown logic in this PR. @vincepri Note that it was not possible to make...

> @inteon Are you currently working on further changes? (just asking because I was about to review the PR) @sbueringer no further changes in the pipeline 😄

@sbueringer should be all resolved.

@vincepri @sbueringer Sorry for making a lot of changes to the PR again. However, I think I found solutions to the remaining questions: 1. I realised that starting the same...

xref: https://github.com/kubernetes-sigs/controller-runtime/issues/2176

@lou-lan I'm not sure what is blocking this PR. I resolved the remaining issues and challenges. Looking for a final review from @vincepri @sbueringer or @FillZpp