Tim Ramlot

/approve /lgtm

@dependabot rebase

> this project (openshift-routes) has to duplicate logic for handling the creation of certificates that already exists in cert-manager. I think this is the case for multiple cert-manager projects: csi-driver,...

Thank you for fixing this issue @jacksgt. fixed in https://github.com/cert-manager/openshift-routes/pull/41

> I love how much this deletes! Mostly my review relates to comments and helping people to use this repo - what do you think? > > Also, I think...

@oliverchang @jonathanmetzman @DonggeLiu PTAL This PR has been approved, but is not being auto-merged.

The example `CertificateTemplateOverrideDuration` function would work. "logic itself will have to be implemented by each issuer individually" refers to the fact that cert-manager has 5 in-tree issuers and a lot...

I think all comments have been addressed now. Thank you for this feature! /approve /lgtm /unhold

/approve

This PR was implemented in https://github.com/cert-manager/cert-manager/pull/7013, https://github.com/cert-manager/cert-manager/pull/7015 and https://github.com/cert-manager/cert-manager/pull/7014.