IntelOwl icon indicating copy to clipboard operation
IntelOwl copied to clipboard

some analyzer are missing the monkeypatch and so the tests

Open mlodic opened this issue 2 years ago • 3 comments

  • [ ] https://github.com/intelowlproject/IntelOwl/blob/master/api_app/analyzers_manager/observable_analyzers/cymru.py
  • [x] https://github.com/intelowlproject/IntelOwl/blob/master/api_app/analyzers_manager/observable_analyzers/mb_google.py
  • [ ] https://github.com/intelowlproject/IntelOwl/blob/master/api_app/analyzers_manager/observable_analyzers/tor.py
  • [x] some docker-based analyzers like Thug
  • [ ] others?

@eshaan7 do you think there is a reason for that or they just miss?

mlodic avatar Jan 10 '22 09:01 mlodic

  1. Did not add monkeypatches in cymru and tor because I thought we wanted to actually check that the tor downloader works (or I think they somehow got missed between all the refactoring? not sure). Anyways, it could make sense to add them.
  2. The monkeypatch in mb_google comes from mb_get via class inheritance.
  3. The monkeypatch is not defined individually in docker based analyzers instead it is defined only once in the DockerBasedAnalyzer base class.

eshaan7 avatar Jan 10 '22 09:01 eshaan7

thanks for the explanation. I think that we can consider tor and cymru like the others and mock them. I'll keep the issue open so.

mlodic avatar Jan 10 '22 09:01 mlodic

@eshaan7 and @mlodic can you tell me what I need to do in order to do this task since I'm not familiar with monkey patch and all. Thank you!

fear-the-reaper avatar May 04 '22 05:05 fear-the-reaper

in #1163 I added tests for Talos and Tor. I think that is enough to close the issue

mlodic avatar Aug 19 '22 16:08 mlodic