IntelOwl
IntelOwl copied to clipboard
some analyzer are missing the monkeypatch and so the tests
- [ ] https://github.com/intelowlproject/IntelOwl/blob/master/api_app/analyzers_manager/observable_analyzers/cymru.py
- [x] https://github.com/intelowlproject/IntelOwl/blob/master/api_app/analyzers_manager/observable_analyzers/mb_google.py
- [ ] https://github.com/intelowlproject/IntelOwl/blob/master/api_app/analyzers_manager/observable_analyzers/tor.py
- [x] some docker-based analyzers like Thug
- [ ] others?
@eshaan7 do you think there is a reason for that or they just miss?
- Did not add monkeypatches in
cymru
andtor
because I thought we wanted to actually check that the tor downloader works (or I think they somehow got missed between all the refactoring? not sure). Anyways, it could make sense to add them. - The monkeypatch in
mb_google
comes frommb_get
via class inheritance. - The monkeypatch is not defined individually in docker based analyzers instead it is defined only once in the
DockerBasedAnalyzer
base class.
thanks for the explanation. I think that we can consider tor and cymru like the others and mock them. I'll keep the issue open so.
@eshaan7 and @mlodic can you tell me what I need to do in order to do this task since I'm not familiar with monkey patch and all. Thank you!
in #1163 I added tests for Talos and Tor. I think that is enough to close the issue