IntelOwl icon indicating copy to clipboard operation
IntelOwl copied to clipboard

Watchman should not be downloaded in CI or production images

Open mlodic opened this issue 1 year ago • 3 comments

this should be downloaded only for local development

mlodic avatar Apr 12 '24 14:04 mlodic

Hello, not sure if this is correct issue but the default value of $WATCHMAN envar in Dockerfile is set incorrectly. It is set to false, however, watchman install script requires False, with capital F, to not install Watchman.

If you try to rebuild the image from repository, you can see Saving to: ‘watchman-v2024.02.12.00-linux.zip’ in output logs. However, if you set $WATCHMAN="False", you will see Skipping WATCHMAN installation because we are not in test mode.

geckiss avatar May 14 '24 12:05 geckiss

hey @geckiss thank you very much for your help. I think we are pretty bad with typos and so on 🤣 so please could you open a very little PR request to show the exact change that you have done? In this way we can understand it better and you can also get credit for your contribution :)

mlodic avatar May 14 '24 12:05 mlodic