PhoneInfoga#995

[g4ze]

closes #995

Description

Add phoneinfoga_scan analyzer

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue).
• [x] New feature (non-breaking change which adds functionality).
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

• [x] I have read and understood the rules about how to Contribute to this project
• [x] The pull request is for the branch develop
• [x] A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
  • [x] I strictly followed the documentation "How to create a Plugin"
  • [x] Usage file was updated.
  • [x] Advanced-Usage was updated (in case the plugin provides additional optional configuration).
  • [x] If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
  • [x] I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
  • [x] If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
  • [x] If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
  • [x] Check if it could make sense to add that analyzer/connector to other freely available playbooks.
  • [x] I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
• [x] If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
• [x] Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
• [x] I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
• [x] If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
• [ ] If the GUI has been modified:
  • [ ] I have a provided a screenshot of the result in the PR.
  • [ ] I have created new frontend tests for the new component or updated existing ones.

Important Rules

• If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
• If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
• Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

raw json: {"result":{"valid":true,"number":"33679368229","local_format":"0679368229","international_format":"+33679368229","country_prefix":"+33","country_code":"FR","country_name":"France","location":"","carrier":"Orange France SA","line_type":"mobile"}}

[g4ze]

I still need to update docs and make migrations

[g4ze]

Docs done

[g4ze]

Hello! @mlodic , this took me sometime to get done. The test is failing here. It pertains to the migration file. I used the dumpplugin comand to create the file. I've crossed checked it with the way previous migrations are written. Still can't seem to find out why this is happening.

[mlodic]

the migration error is here:

  File "/opt/deploy/intel_owl/api_app/analyzers_manager/migrations/0064_analyzer_config_phoneinfoga.py", line 118, in migrate
    _create_object(PluginConfig, value)

I think that there is some problem with the IDs

django.db.utils.IntegrityError: duplicate key value violates unique constraint "api_app_parameter_name_python_module_id_85f61e18_uniq"

I think that could be the error, I asking to @0ssigeno a second opinion

[0ssigeno]

Checking

[0ssigeno]

Oki fixed, the error now should be on your side.

[g4ze]

thankyou very much, I'll look into it.

[g4ze]

the tests are now successful. Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3.1.0/dist/codecov' failed with exit code 255 is this on my end? kindly review.

[g4ze]

apart from this I'll update the migrations as a new analyzer Zippy_scan was added.

[g4ze]

uhoh, i did it again; overlooked a checkpoint. Made required migrations(agn)

[g4ze]

it worked lol. @mlodic any other changes?

[mlodic]

Just to keep a reference, they answered herehttps://github.com/https://github.com/sundowndev/phoneinfoga/issues/1393)

We'll wait them to solve the issue regarding API keys than we'll finish this PR

[g4ze]

works using new version of phoneinfoga

[g4ze]

@mlodic kindly review.

[mlodic]

let's wait for the tests. If they pass we can merge the PR. Ty!