react-pdf icon indicating copy to clipboard operation
react-pdf copied to clipboard

Published 20 hours ago • verified publisher icon intelllex

Feature request for "Print" option

Open ghanshyam-1805 opened this issue 4 years ago • 7 comments

Is possible to add a print option in the toolbox?

ghanshyam-1805 avatar Oct 28 '20 08:10 ghanshyam-1805

hi @ghanshyam-1805 , yes, it is possible, but right now our react-pdf has had it yet. How about we provide an option to add a print icon? When the user clicks on the print icon, we will save that pdf to your device?

trinhngocdieu avatar Oct 29 '20 06:10 trinhngocdieu

There will be good if the native print popup will be open on click of the print icon, the Download option will be a new feature if anyone required.

ghanshyam-1805 avatar Oct 29 '20 09:10 ghanshyam-1805

@trinhngocdieu What's your suggestion?

ghanshyam-1805 avatar Oct 29 '20 11:10 ghanshyam-1805

@ghanshyam-1805 , sorry for late response. I think it is possible, I will update and let you know soon.

trinhngocdieu avatar Oct 30 '20 09:10 trinhngocdieu

@trinhngocdieu Thanks.

ghanshyam-1805 avatar Oct 30 '20 09:10 ghanshyam-1805

@trinhngocdieu I have found one issue and enhancement,

  1. Zoom issue: When we continuously press the "zoom-out" button it throws an error in the console that "PDFViewer._setScale: "-0.19999999999999996" is an unknown zoom value." and PDF got invisible.
  2. Enhancement: While scrolling the PDF, thumbnails should also scroll according to the page.

It would be great if you look at these also.

Thanks!

ghanshyam-1805 avatar Oct 31 '20 08:10 ghanshyam-1805

@ghanshyam-1805 : Thank you so much, I will try to look and fix them soon. It would be great if you can create a PR, too! :)

trinhngocdieu avatar Nov 02 '20 03:11 trinhngocdieu