intellij-dlanguage
intellij-dlanguage copied to clipboard
intellij-dlanguage
IDE freezes when using VCS Commit Changes dialog
When committing code from within the IDE, the IDE will freeze during the "Performing Code Analysis" step. A hard kill and restart is required, cancel will do nothing. I don't have DFormat and DScanner configured.
An obvious work-around is to disable "Perform code analysis" under the "Before Commit" options.
Possibly related to #228?
Windows 10 64-bit, IntelliJ IDEA 2017.2.2
This issue is caused by net.masterthought.dlanguage.highlighting.annotation.external.DExternalAnnotator#doAnnotate trying to save all files, in order to sync the displayed files and the files that the external annotators are annotating. When in the vcs dialog, the external annotators are called, but cannot save all files, due to the vcs action blocking writes somehow.
Nope. These are the last lines in the log I see when crashed:
2019-03-27 21:47:48,633 [16860795] INFO - lij.compiler.impl.CompilerUtil - COMPILATION FINISHED (BUILD PROCESS); Errors: 0; warnings: 0 took 106 ms: 0 min 0sec
2019-03-27 21:47:48,647 [16860809] INFO - s.CompilerReferenceServiceBase - backward reference index reader is opened
2019-03-27 21:47:48,983 [16861145] INFO - j.compiler.server.BuildManager - BUILDER_PROCESS [stdout]: Build process started. Classpath: C:/Program Files/JetBrains/IntelliJ IDEA 2018.3.3/lib/jps-launcher.jar;C:/Program Files (x86)/Java/jdk1.8.0_151/lib/tools.jar;C:/Program Files/JetBrains/IntelliJ IDEA 2018.3.3/lib/optimizedFileManager.jar
2019-03-27 21:47:49,022 [16861184] INFO - j.compiler.server.BuildManager - BUILDER_PROCESS [stderr]: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
2019-03-27 21:47:49,022 [16861184] INFO - j.compiler.server.BuildManager - BUILDER_PROCESS [stderr]: SLF4J: Defaulting to no-operation (NOP) logger implementation
2019-03-27 21:47:49,022 [16861184] INFO - j.compiler.server.BuildManager - BUILDER_PROCESS [stderr]: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
In IntelliJ it crashes in the sense that wherever I click, I hear the windows "bing" but there is no action on the screen. Nothing is clickable. CPU usage in Task Manager is 0%.
@benjo456 Do you have "Reformat Code", "Perform Code Analysis", "Optimize Imports", or "Cleanup", enabled in the commit dialog? If so the issue is likely the same as before, which is that dfmt/dscanner need a lock on files, while the commit dialog has already acquired that lock.
I'm not sure as I cannot access the commit dialogue
On Wed, Mar 27, 2019, 23:43 Francis Nixon [email protected] wrote:
@benjo456 https://github.com/benjo456 Do you have "Reformat Code", "Perform Code Analysis", "Optimize Imports", or "Cleanup", enabled in the commit dialog? If so the issue is likely the same as before, which is that dfmt/dscanner need a lock on files, while the commit dialog has already acquired that lock.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intellij-dlanguage/intellij-dlanguage/issues/232#issuecomment-477388244, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLRA-yEu8aZ30K3Q5X5dbfThjdpULeDks5vbAIFgaJpZM4O8nb- .
I've been trying to reproduce this and haven't been able. What OS are you on/what versions of dcd/dfmt/dscanner/dub/dmd are you using?
Comfirming hard freeze when IDE commit performes Reformat Code action.
PhpStorm 2019.1 Build #PS-191.6183.95, built on March 27, 2019 Linux 4.15.0-46-generic OS Linux Mint,
I get freezes after commits even when just doing them via terminal. On Windows 10 that is.
Experiencing same issue in this version: <<< IntelliJ IDEA 2019.3.3 (Ultimate Edition) Build #IU-193.6494.35, built on February 11, 2020 ... Subscription is active until February 28, 2022 Runtime version: 11.0.5+10-b520.38 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o Windows 10 10.0 GC: ParNew, ConcurrentMarkSweep Memory: 1956M Cores: 12 Registry: debugger.watches.in.variables=false Non-Bundled Plugins: Pythonid, aws.toolkit, training
Get this issue right after my IT updating my windows 10 version, after the second reboot. Maybe there are other tools the IT department updated. I don't know. New windows version is <<< OS Name Microsoft Windows 10 Enterprise Version 10.0.18363 Build 18363 Hardware Abstraction Layer Version = "10.0.18362.1171"
SOLUTION:
One important thing is, when pressing Alt-F4, it unfreezes the Intellij app. So my bet is the commit window is somehow hidden, maybe minimized.
Ok, I did additional testing. I have several displays, but could not see the commit popup window anywhere, but doing on keyboard: . Left-Window +up arrow (enlarge window) then . Left-Window + right arrow (move to next half right part of screen)
Made it appear correctly. You may need to repeat the last key several times (or using the left arrow instead of the right one) depending on you screen configuration. Hope this helps.
