dlrover
dlrover copied to clipboard
add exception handler in _get_master_addr_port since the port might b…
What changes were proposed in this pull request?
add try-exception to protect _get_master_addr_port and add retry of the calling to relieve the port sync problem
Why are the changes needed?
the return value of _get_master_addr_port may be invalid
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT
Codecov Report
Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
Project coverage is 80.37%. Comparing base (
0ef290a) to head (b466f01). Report is 34 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| dlrover/python/elastic_agent/torch/training.py | 55.55% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
+ Coverage 80.34% 80.37% +0.02%
==========================================
Files 222 222
Lines 20481 20525 +44
==========================================
+ Hits 16456 16496 +40
- Misses 4025 4029 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.