subrion
subrion copied to clipboard
SECURITY ISSUE - File Permissions on uploads and folders
I found a security issue. On uploads it automatically changes folder permissions to 777 and files to 666. This shouldnt be. Many servers will throw an error with this if the site is running in the proper configuration there should. Doing a search for "0777" within the files of subrion shows this in MANY files. Anywhere you can upload anything. All of that needs to be changed at least to 755, the same issue remains with the files should be 644. This is a big risk and should be fixed quickly. At the very least there should be a config option to let us choose what permissions we want to use for folders and files incase people have websites that have to use 777 and 666 even though its not safe.
Here are a few files that have the issue: admin\configuration.php front\actions.php includes\classes\ia.core.cache.php includes\classes\ia.core.smarty.php includes\classes\ia.core.util.php includes\classes\ia.core.view.php includes\elfinder\php\elFinderVolumeDrive.class.php includes\elfinder\php\elFinderVolumeLocalFileSystem.class.php includes\htmlpurifier\HTMLPurifier\DefinitionCache\Seriializer.php includes\PHPImageWorkshop\Core\ImageWorkshopLayer.php includes\smarty/sysplugins\smarty_internal_write_file.php includes\utils\pclzip.lib.php install\classes\ia.helper.php install\classes\ia.patch.applier.php nodules\banners\includes\classes\ia.admin.banner.php
There are more but this is at first glance.