zephyr.js
zephyr.js copied to clipboard
ashell: JS eval error messages are not terminated with a newline character
All messages that I receive from ashell are terminated with CRLF, but when I try to run some JS code that has errors in it, the messages I receive are only terminated with CR, and no LF.
Because of that, my terminal will perform a CR and then overwrite the same line with the next message, garbling the text.
This need bit more planning. That is, we need to separate at least the following data types inside the Web USB connection.
- Control messages between the IDE and ashell (ACK, RUN, etc)
- JavaScript console messages (via console.log)
- JavaScript engine error messages (e.g. Syntax error in line 7, etc)
We need a protocol to make this robust and easy to extend.
Until we get around to the newer protocol, I added the newlines. https://github.com/01org/zephyr.js/pull/972
@brianjjones please check status.