scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

MAINT: Update skipped tests for sklearn1.8

Open david-cortes-intel opened this issue 1 month ago • 7 comments

Description

As part of the updates for changes in sklearn1.8's logistic regression, some tests appear to have been adapted only partially. This PR removes a failing test for functionality that's being removed in sklearn1.8 and which is currently causing CI failures on the nightly jobs.


Checklist:

Completeness and readability

  • [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • [x] I have resolved any merge conflicts that might occur with the base branch.

Testing

  • [x] All CI jobs are green or I have provided justification why they aren't.

david-cortes-intel avatar Nov 21 '25 09:11 david-cortes-intel

/azp run Nightly

david-cortes-intel avatar Nov 21 '25 09:11 david-cortes-intel

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 21 '25 09:11 azure-pipelines[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure ?
github 82.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more. see 33 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 21 '25 10:11 codecov[bot]

Looks like it fixed the issue, but note that the CI jobs still fail due to other unrelated reasons.

david-cortes-intel avatar Nov 21 '25 14:11 david-cortes-intel

At that point, a pytest.skipif(not sklearn_check_version("1.8"), reason="no longer relevant in sklearn >1.8") may be clearer

icfaust avatar Nov 21 '25 22:11 icfaust

At that point, a pytest.skipif(not sklearn_check_version("1.8"), reason="no longer relevant in sklearn >1.8") may be clearer

Modified to use skipif.

david-cortes-intel avatar Nov 24 '25 07:11 david-cortes-intel

At that point, a pytest.skipif(not sklearn_check_version("1.8"), reason="no longer relevant in sklearn >1.8") may be clearer

Actually not possible, because it requires instantiating the model objects with the removed arguments before the test is skipped.

david-cortes-intel avatar Nov 26 '25 09:11 david-cortes-intel

Same change was made by another PR that got merged before this: https://github.com/uxlfoundation/scikit-learn-intelex/pull/2847

david-cortes-intel avatar Dec 11 '25 11:12 david-cortes-intel