MAINT: Update skipped tests for sklearn1.8
Description
As part of the updates for changes in sklearn1.8's logistic regression, some tests appear to have been adapted only partially. This PR removes a failing test for functionality that's being removed in sklearn1.8 and which is currently causing CI failures on the nightly jobs.
Checklist:
Completeness and readability
- [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
- [x] I have resolved any merge conflicts that might occur with the base branch.
Testing
- [x] All CI jobs are green or I have provided justification why they aren't.
/azp run Nightly
Azure Pipelines successfully started running 1 pipeline(s).
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
| Flag | Coverage Δ | |
|---|---|---|
| azure | ? |
|
| github | 82.23% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more. see 33 files with indirect coverage changes
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Looks like it fixed the issue, but note that the CI jobs still fail due to other unrelated reasons.
At that point, a pytest.skipif(not sklearn_check_version("1.8"), reason="no longer relevant in sklearn >1.8") may be clearer
At that point, a
pytest.skipif(not sklearn_check_version("1.8"), reason="no longer relevant in sklearn >1.8")may be clearer
Modified to use skipif.
At that point, a
pytest.skipif(not sklearn_check_version("1.8"), reason="no longer relevant in sklearn >1.8")may be clearer
Actually not possible, because it requires instantiating the model objects with the removed arguments before the test is skipped.
Same change was made by another PR that got merged before this: https://github.com/uxlfoundation/scikit-learn-intelex/pull/2847