[enhancement] set specific failure for host builds with "target_offload"
Description
This allows for a standardized interface to all the backends with respect to "SyclQueue" by adding a function to the pybind11 interface. This simplifies the logic for dpc++ builds, and reduces wasted cycles. This acts as the standardized failure point for when someone attempts to use the target_offload sklearnex config with a host build when the value is not "auto".
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed. This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way. For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
- [x] I have reviewed my changes thoroughly before submitting this pull request.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
- [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
- [x] I have added a respective label(s) to PR if I have a permission for that.
- [x] I have resolved any merge conflicts that might occur with the base branch.
Testing
- [x] I have run it locally and tested the changes extensively.
- [x] All CI jobs are green or I have provided justification why they aren't.
- [x] I have extended testing suite if new functionality was introduced in this PR.
Performance
- [x] I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
- [x] I have provided justification why performance has changed or why changes are not expected.
- [x] I have provided justification why quality metrics have changed or why changes are not expected.
- [x] I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
| Flag | Coverage Δ | |
|---|---|---|
| azure | 79.92% <100.00%> (-0.01%) |
:arrow_down: |
| github | 71.60% <100.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| onedal/_device_offload.py | 80.70% <ø> (-0.34%) |
:arrow_down: |
| onedal/common/sycl.cpp | 43.75% <ø> (ø) |
|
| onedal/dal.cpp | 95.65% <100.00%> (ø) |
|
| onedal/utils/_sycl_queue_manager.py | 73.84% <100.00%> (-1.52%) |
:arrow_down: |
| sklearnex/_config.py | 100.00% <ø> (ø) |
... and 2 files with indirect coverage changes
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/intelci: run
/intelci: run
Docs fix is required.
remove change in operation wrt cpu as it's not always guaranteed to work with a dpc backend. now its only looking for auto therefore changes don't need to be made
/intelci: run
/intelci: run