scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

[Enhancement] WIP new finite checking in ```EmpiricialCovariance``` and ```IncrementalEmpiricalCovariance```

Open icfaust opened this issue 1 year ago • 3 comments

Description

Add new finite checking to EmpricalCovariance


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed. This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way. For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • [ ] I have reviewed my changes thoroughly before submitting this pull request.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • [ ] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • [ ] I have added a respective label(s) to PR if I have a permission for that.
  • [ ] I have resolved any merge conflicts that might occur with the base branch.

Testing

  • [ ] I have run it locally and tested the changes extensively.
  • [ ] All CI jobs are green or I have provided justification why they aren't.
  • [ ] I have extended testing suite if new functionality was introduced in this PR.

Performance

  • [ ] I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • [ ] I have provided justification why performance has changed or why changes are not expected.
  • [ ] I have provided justification why quality metrics have changed or why changes are not expected.
  • [ ] I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

icfaust avatar Dec 03 '24 14:12 icfaust

/intelci: run

icfaust avatar Dec 04 '24 06:12 icfaust

/intelci: run

icfaust avatar Dec 04 '24 07:12 icfaust

This PR is now dependent on the developments in #2096 (SPMD testing requires array_api bypassing on oneDAL offloading)

icfaust avatar Dec 04 '24 09:12 icfaust

Codecov Report

:x: Patch coverage is 72.30769% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sklearnex/covariance/incremental_covariance.py 65.43% 24 Missing and 4 partials :warning:
sklearnex/utils/_array_api.py 83.33% 3 Missing and 3 partials :warning:
onedal/covariance/incremental_covariance.py 83.33% 1 Missing and 1 partial :warning:
Flag Coverage Δ
azure 80.80% <70.76%> (-0.07%) :arrow_down:
github 73.20% <72.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/covariance/covariance.py 88.88% <100.00%> (+5.16%) :arrow_up:
onedal/covariance/incremental_covariance.py 93.87% <83.33%> (+5.41%) :arrow_up:
sklearnex/utils/_array_api.py 91.42% <83.33%> (-8.58%) :arrow_down:
sklearnex/covariance/incremental_covariance.py 79.53% <65.43%> (-10.61%) :arrow_down:

... and 42 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 11 '25 14:07 codecov[bot]

/intelci: run

icfaust avatar Jul 14 '25 21:07 icfaust

/intelci: run

icfaust avatar Jul 16 '25 06:07 icfaust

/intelci: run

icfaust avatar Jul 16 '25 07:07 icfaust

/intelci: run

Alexsandruss avatar Jul 31 '25 10:07 Alexsandruss

/intelci: run

icfaust avatar Aug 07 '25 13:08 icfaust

/intelci: run

icfaust avatar Aug 08 '25 22:08 icfaust

/intelci: run

icfaust avatar Aug 10 '25 23:08 icfaust

/intelci: run

icfaust avatar Aug 11 '25 12:08 icfaust

/intelci: run

icfaust avatar Aug 11 '25 18:08 icfaust

/intelci: run

icfaust avatar Aug 11 '25 20:08 icfaust

/intelci: run

icfaust avatar Aug 11 '25 22:08 icfaust

/intelci: run

icfaust avatar Aug 12 '25 22:08 icfaust

Private CI failure comes from an infrastructure timeout.

icfaust avatar Aug 13 '25 12:08 icfaust