scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

[enh] Conda recipe update and CI OS version pinning

Open Alexsandruss opened this issue 1 year ago • 6 comments

Description

Scikit-learn-intelex conda recipe update.

Changes:

  • Update content of recipe, building and testing scripts to sync with conda-forge feedstock
  • Add recipe building on Linux and Windows to CI
  • Pin CI images versions
  • Add hint for CMake to get python executable from $PYTHON if set

Conda-forge checks: https://github.com/conda-forge/scikit-learn-intelex-feedstock/pull/38


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • [x] I have reviewed my changes thoroughly before submitting this pull request.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • [x] I have added a respective label(s) to PR if I have a permission for that.
  • [x] I have resolved any merge conflicts that might occur with the base branch.

Testing

  • [x] The unit tests pass successfully.
  • [x] I have run it locally and tested the changes extensively.

Performance

  • [x] I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • [x] I have provided justification why performance has changed or why changes are not expected.

Alexsandruss avatar Aug 07 '24 12:08 Alexsandruss

/intelci: run

Alexsandruss avatar Aug 08 '24 12:08 Alexsandruss

/intelci: run

Alexsandruss avatar Aug 13 '24 16:08 Alexsandruss

/intelci: run

Alexsandruss avatar Aug 14 '24 07:08 Alexsandruss

/intelci: run

Alexsandruss avatar Aug 15 '24 12:08 Alexsandruss

/iintelci: run

Alexsandruss avatar Aug 26 '24 21:08 Alexsandruss

/intelci: run

icfaust avatar Aug 28 '24 22:08 icfaust

@Alexsandruss please rebase your branch.

samir-nasibli avatar Sep 10 '24 06:09 samir-nasibli

/intelci: run

Alexsandruss avatar Sep 20 '24 14:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 20 '24 17:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 23 '24 09:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 23 '24 12:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 25 '24 15:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 25 '24 15:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 25 '24 18:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 26 '24 09:09 Alexsandruss

/intelci: run

Alexsandruss avatar Sep 30 '24 20:09 Alexsandruss

/intelci: run

Alexsandruss avatar Oct 14 '24 14:10 Alexsandruss

/intelci: run

Alexsandruss avatar Oct 15 '24 16:10 Alexsandruss

/intelci: run

Alexsandruss avatar Oct 16 '24 07:10 Alexsandruss

Question: are the commands in meta.yaml for executing tests actually needed if it will end up calling the run_test.sh/bat scripts in the end? E.g. do they execute somewhere else too?

david-cortes-intel avatar Oct 16 '24 08:10 david-cortes-intel

/intelci: run

Alexsandruss avatar Oct 18 '24 14:10 Alexsandruss

@Alexsandruss This was merged with an error in the WindowsCondaEnv Python3.12_Sklearn1.5 step

icfaust avatar Oct 21 '24 09:10 icfaust

@Alexsandruss This was merged with an error in the WindowsCondaEnv Python3.12_Sklearn1.5 step

The error appears to be sporadic though.

david-cortes-intel avatar Oct 21 '24 09:10 david-cortes-intel