scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

ENH: SPMD interface for IncrementalPCA

Open olegkkruglov opened this issue 6 months ago • 4 comments

Description

  • Added SPMD interface for IncrementalEmpiricalCovariance
  • Changed policy saving workflow, now queue is saved to attributes instead of policy. It is necessary because finalize_fit requires spmd_policy, but partial_fit requires data_parallel_policy on oneDAL side
  • finalize_fit now uses provided queue for computations on onedal4py side.
  • Contains some content from https://github.com/intel/scikit-learn-intelex/pull/1777 for test implementation

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • [x] I have reviewed my changes thoroughly before submitting this pull request.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • [x] I have added a respective label(s) to PR if I have a permission for that.
  • [x] I have resolved any merge conflicts that might occur with the base branch.

Testing

  • [x] The unit tests pass successfully.
  • [x] I have run it locally and tested the changes extensively.

Performance

  • [ ] I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • [ ] I have provided justification why performance has changed or why changes are not expected.

olegkkruglov avatar Jul 31 '24 00:07 olegkkruglov