scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

[fix] solve various windows onedal build warnings

Open icfaust opened this issue 6 months ago • 6 comments

We have a number of these errors in the compilation stage in windows for onedal: warning C4101: 'e': unreferenced local variable

Add static casts to double type where implicit conversion had been previously done.

Following the guide of this StackOverflow post: https://stackoverflow.com/questions/24428146/catching-exception-with-unreferenced-local-variable-warning by casting to void, it will tell the compiler it is unused, but will not impact the output machine code.

Fix belt-and-suspenders setting of variable to const std::int64_t to int as required by numpy interfaces.

Remove unused variables and type aliases (icx compiler complains on windows)

icfaust avatar Jul 30 '24 09:07 icfaust