scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

ENH: Added serialization for IncrementalPCA

Open olegkkruglov opened this issue 7 months ago • 3 comments

Description

  • Contains changes from https://github.com/intel/scikit-learn-intelex/pull/1924 which are necessary for correctly working multiple times serialization/deserialization
  • Added __getstate__ and __setstate__ methods to IncrementalPCA
  • Finalization is called with serialization during __getstate__ method
  • _need_to_finalize flag is added to avoid unnecessary call of finalization backend.
  • Added test for checking if it works well
  • Updated deselected_tests.yaml
  • [x] I have reviewed my changes thoroughly before submitting this pull request.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have updated the documentation to reflect the changes, if necessary.
  • [x] The unit tests pass successfully.
  • [x] I have run it locally and tested the changes extensively.
  • [x] I have resolved any merge conflicts that might occur with the base branch.
  • [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)
  • [x] I have added a respective label(s) to PR if I have a permission for that.

olegkkruglov avatar Jul 09 '24 14:07 olegkkruglov