scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

TEST: using `pytest.skip` instead of `device_filter`

Open samir-nasibli opened this issue 2 weeks ago • 8 comments

Description

  • Using pytest.skip instead of device_filter when case is buggy.
  • Added docstrings for get_dataframes_and_queues, _convert_to_dataframe and get_queues utilities.
  • Backlog reviewed for tickets on TODO comment sections that were removed. All cases covered.

TODO

  • will be done in separate PR the same idea for _dataframe_filter, when case for exact dataframe lib is buggy
  • [x] I have reviewed my changes thoroughly before submitting this pull request.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have updated the documentation to reflect the changes, if necessary (updated in # - add PR number)
  • [x] The unit tests pass successfully.
  • [x] I have run it locally and tested the changes extensively.
  • [x] I have resolved any merge conflicts that might occur with the base branch.
  • [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)
  • [x] I have added a respective label(s) to PR if I have a permission for that.

samir-nasibli avatar Jun 24 '24 23:06 samir-nasibli