scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

Published 20 hours ago • verified publisher icon intel

FEAT(forest): hyperparameter support for RF clf inference

Open ahuber21 opened this issue 1 year ago • 17 comments

Description

Add hyperparameters to Random Forest classification inference, corresponding oneDAL changes in https://github.com/oneapi-src/oneDAL/pull/2638

  • Add hyperparameters to forest.py & forest.cpp where supported by oneDAL
  • Add tests that set a range of possible values and run inference

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • [x] I have reviewed my changes thoroughly before submitting this pull request.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • [x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • [x] I have added a respective label(s) to PR if I have a permission for that.
  • [x] I have resolved any merge conflicts that might occur with the base branch.

Testing

  • [x] I have run it locally and tested the changes extensively.
  • [ ] All CI jobs are green or I have provided justification why they aren't.
  • [x] I have extended testing suite if new functionality was introduced in this PR.

Performance

does not apply

ahuber21 avatar Feb 29 '24 14:02 ahuber21

/intelci: run

ahuber21 avatar Feb 29 '24 14:02 ahuber21

CI with oneDAL updates http://intel-ci.intel.com/eed70e1a-9c78-f185-8d8e-a4bf010d0e2e

ahuber21 avatar Feb 29 '24 14:02 ahuber21

/intelci: run

ahuber21 avatar Mar 12 '24 17:03 ahuber21

CI with branch from oneDAL#2638

http://intel-ci.intel.com/eee09489-921d-f165-8b50-a4bf010d0e2e

ahuber21 avatar Mar 12 '24 17:03 ahuber21

/intelci: run

ahuber21 avatar Mar 12 '24 23:03 ahuber21

Updated run with changes from 2638 http://intel-ci.intel.com/eee0cbf3-f8dd-f171-9c4f-a4bf010d0e2e

ahuber21 avatar Mar 12 '24 23:03 ahuber21

Benchmarks: http://intel-ci.intel.com/eee0cf89-b051-f1ed-a729-a4bf010d0e2e

ahuber21 avatar Mar 13 '24 00:03 ahuber21

/intelci: run

ahuber21 avatar Mar 14 '24 14:03 ahuber21

Updated job with oneDAL + scikit-learn-intelex changes http://intel-ci.intel.com/eee23804-7d24-f117-86db-a4bf010d0e2e

ahuber21 avatar Mar 14 '24 19:03 ahuber21

Is "hyperparameters" just another name for performance tuning parameters?

KulikovNikita avatar Mar 28 '24 11:03 KulikovNikita

@Vika-F are we able to finalize this one?

ethanglaser avatar Apr 29 '24 15:04 ethanglaser

@Vika-F @ethanglaser @icfaust @avolkov-intel Who is expected to be next assigned to this job done?

samir-nasibli avatar Jun 14 '24 09:06 samir-nasibli