scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

feat: display warning if patch_sklearn() called after sklearn imports

Open ahuber21 opened this issue 1 year ago • 1 comments

ahuber21 avatar Feb 15 '24 11:02 ahuber21

Had to get a little creative, but it seems to be doing fine now. Please let me know what you think @icfaust @napetrov

ahuber21 avatar Feb 16 '24 14:02 ahuber21

/intelci: run

ethanglaser avatar Feb 28 '24 22:02 ethanglaser

/azp run

ethanglaser avatar Feb 28 '24 22:02 ethanglaser

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Feb 28 '24 22:02 azure-pipelines[bot]

/intelci: run

ahuber21 avatar Feb 29 '24 14:02 ahuber21

/azp run

ahuber21 avatar Feb 29 '24 14:02 ahuber21

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 29 '24 14:02 azure-pipelines[bot]

/azp run CI

ethanglaser avatar Feb 29 '24 14:02 ethanglaser

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 29 '24 14:02 azure-pipelines[bot]

/intelci: run

ahuber21 avatar Mar 05 '24 08:03 ahuber21

Loading something from sklearnex brings in so much stuff from sklearn it's really tough to tell if we already have some instances of sklearn classes. In my latest commit I tried querying all objects from the garbage collector, but event that's unreliable. On top, it's very slow. I don't see a good way of implementing this feature right now. Closing.

ahuber21 avatar Mar 12 '24 00:03 ahuber21