scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

Published 20 hours ago • verified publisher icon intel

Refactor linear regression

Open olegkkruglov opened this issue 1 year ago • 2 comments

Changes proposed in this pull request:

  • Remove version checks
  • Rearrange methods between Base and inherited classes in onedal
  • Remove Base class in sklearnex
  • Remove unnecessary variables

These changes are necessary for more convenient adding of IncrementalLinearRegression

olegkkruglov avatar Feb 14 '24 13:02 olegkkruglov

/intelci: run

olegkkruglov avatar Feb 14 '24 14:02 olegkkruglov

/intelci: run

olegkkruglov avatar Feb 22 '24 14:02 olegkkruglov

/intelci: run

olegkkruglov avatar Feb 27 '24 14:02 olegkkruglov

/intelci: run

ethanglaser avatar Mar 04 '24 17:03 ethanglaser

/intelci: run

olegkkruglov avatar Mar 05 '24 10:03 olegkkruglov

/intelci: run

olegkkruglov avatar Mar 07 '24 09:03 olegkkruglov

/intelci: run

olegkkruglov avatar Mar 07 '24 12:03 olegkkruglov

/intelci: run

olegkkruglov avatar Mar 07 '24 13:03 olegkkruglov

/intelci: run

olegkkruglov avatar Mar 07 '24 20:03 olegkkruglov

https://ecmd.jf.intel.com/commander/link/jobDetails/jobs/eedd311d-0051-f112-bf14-a4bf010d0e2e

olegkkruglov avatar Mar 08 '24 09:03 olegkkruglov

/intelci: run

olegkkruglov avatar Mar 21 '24 14:03 olegkkruglov

/intelci: run

ethanglaser avatar Mar 21 '24 23:03 ethanglaser

Regarding version check removal: here it was completely redundant since it is duplicated there: https://github.com/intel/scikit-learn-intelex/blob/c9a1f446b4698162a9e612c61663888ccf15914f/setup.py#L556

By the way, do we have strict policy regarding such version checks? It looks like there are just few algos where it is used

olegkkruglov avatar Mar 21 '24 23:03 olegkkruglov

By the way, do we have strict policy regarding such version checks? It looks like there are just few algos where it is used

Nothing formal as far as I know

ethanglaser avatar Mar 22 '24 00:03 ethanglaser

Branch is 14 commits behind main, try to rebase and then re-run internal CI

ethanglaser avatar Mar 22 '24 00:03 ethanglaser

/intelci: run

olegkkruglov avatar Mar 22 '24 01:03 olegkkruglov

master bench: https://ecmd.jf.intel.com/commander/link/jobDetails/jobs/eee78d85-f7d2-f1eb-8305-a4bf010d0e2e this branch bench: https://ecmd.jf.intel.com/commander/link/jobDetails/jobs/eee7cdd9-bd56-f120-821d-a4bf010d0e2e there are no performance changes and ci is green

olegkkruglov avatar Mar 22 '24 11:03 olegkkruglov