scikit-learn-intelex
scikit-learn-intelex copied to clipboard
intel
[enhancement] Add guard for sklearn fallback in sklearnex testing
Description
Sklearnex should not fall back to sklearn unless explicitly allowed to do so in sklearnex testing. This may otherwise mask problems with sklearnex code. Adding a conftest.py with proper pytest hook wrappers will enforce that sklearnex tests work for testing sklearnex functionality (and not sklearn). This also adds a pytest mark ("allow_sklearn_fallback") which will allow for this secondary verification to be turned off if necessary (and thereby is made apparent at the definition of the test).
Changes proposed in this pull request:
- Add conftest.py and a hook into the sklearnex logger
Guard activated against a sklearnex random forest test with GPU, will need to investigate and correct this before merge.
Activating random forest to GPU now causes new sklearn test failures on gpu, this aspect has been split off into #1696 . The status of the gpu test failures in sklearn testing will now be re-evaluated
Activating random forest to GPU now causes new sklearn test failures on gpu, this aspect has been split off into #1696 . The status of the gpu test failures in sklearn testing will now be re-evaluated
Please, deselect this tests here, if no fix in this PR.
direct rerun was successful (green) http://intel-ci.intel.com/eed561eb-399f-f108-89a9-a4bf010d0e2e