scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

Published 20 hours ago • verified publisher icon intel

[enhancement] Add IncrementalEmpiricalCovariance to patch_map

Open icfaust opened this issue 1 year ago • 14 comments

Description

IncrementalEmpiricalCovariance update to match sklearnex estimator characteristics

Changes proposed in this pull request:

  • Add mahalanobis method using sklearnex pairwise_distances to IncrementalEmpiricalCovariance
  • Add error_norm
  • Add onedal_cpu_support and onedal_gpu_support to IncrementalEmpiricalCovariance
  • Add BaseEstimator to IncrementalEmpiricalCovariance inheritance
  • Add wrap_output_data where necessary in IncrementalEmpiricalCovariance
  • Fix covariance_ and location_ attributes to report as not existing before fit
  • Add n_features_in_ attribute for sklearn conformity
  • Add n_samples_seen_ attribute to match style of IncrementalPCA
  • Add init keywords to match sklearn EmpiricalCovariance
  • Add store_precision functionality
  • Add assume_centered functionality
  • Add relevant sklearn tests to sklearnex tests via a separate monkeypatch

Tasks

  • [x] Implement changes for sklearnex/sklearn conformance
  • [x] Add to patchmap to access sklearn tests
  • [x] Modify patchmap to work with new estimators
  • [x] Add EmpiricalCovariance tests from sklearn to test_covariance for IncrementalEmpiricalCovariance
  • [x] Pass Tests
  • [x] Split off changes to patchmap and tests into separate PR

icfaust avatar Jan 26 '24 16:01 icfaust

/Intelci: run

icfaust avatar Jan 28 '24 17:01 icfaust

/intelci: run

icfaust avatar Jan 28 '24 20:01 icfaust

/intelci: run

icfaust avatar Jan 29 '24 11:01 icfaust

/intelci: run

icfaust avatar Jan 29 '24 20:01 icfaust

Will write tickets associated with dataframe0 and test memory leak, it is gpu and cpu side meaning its likely in the glue portion of the code. Also, it only occurs on one of the two meaning something else fishy is going on. This will have to be revisited in the future. I will now slim this PR down and remove the content from the other 3. #1677 #1678 #1676

icfaust avatar Jan 30 '24 05:01 icfaust

/intelci: run

icfaust avatar Jan 30 '24 06:01 icfaust

Code has now been reduced to just changes in IncrementalEmpiricalCovariance

icfaust avatar Jan 30 '24 06:01 icfaust

/intelci: run

icfaust avatar Jan 30 '24 06:01 icfaust

/intelci: run

icfaust avatar Jan 30 '24 09:01 icfaust

Unrelated issue in private CI (logistic regression convergence on cpu)

icfaust avatar Jan 30 '24 11:01 icfaust

/intelci: run

icfaust avatar Jan 30 '24 12:01 icfaust

/intelci: run

icfaust avatar Jan 30 '24 14:01 icfaust

/intelci: run

icfaust avatar Feb 01 '24 09:02 icfaust

If its possible, please wait this pr, for avoid python computation for assume_centered flag support https://github.com/oneapi-src/oneDAL/pull/2658

Alexandr-Solovev avatar Feb 06 '24 15:02 Alexandr-Solovev

/intelci: run

icfaust avatar Apr 12 '24 08:04 icfaust

/intelci: run

icfaust avatar Apr 12 '24 10:04 icfaust

/intelci: run

icfaust avatar Apr 12 '24 19:04 icfaust

/intelci: run

icfaust avatar Apr 16 '24 08:04 icfaust

/intelci: run

icfaust avatar Apr 16 '24 12:04 icfaust

/intelci: run

icfaust avatar Apr 18 '24 11:04 icfaust

/intelci: run

icfaust avatar Apr 22 '24 11:04 icfaust

/intelci: run

icfaust avatar Apr 23 '24 04:04 icfaust

Only Issue is a errant PCA test case failure.

icfaust avatar Apr 23 '24 10:04 icfaust

/intelci: run

icfaust avatar Apr 23 '24 19:04 icfaust

/intelci: run

icfaust avatar Apr 24 '24 07:04 icfaust

Rerun due to openblas issues: http://intel-ci.intel.com/ef02ba38-9fbd-f127-9fb6-a4bf010d0e2e

icfaust avatar Apr 25 '24 04:04 icfaust

/intelci: run

icfaust avatar Apr 25 '24 12:04 icfaust

/intelci: run

icfaust avatar Apr 26 '24 08:04 icfaust