scikit-learn-intelex
scikit-learn-intelex copied to clipboard
intel
ENH: re-impl of onedal backend policies
Description
Updating onedal policies implementation. SPMD policy updated without using dpctl inludes
- Follow-up branch removing DCPTL from the build
Removes real
dpctlbuild dependency
Co-authored-by: Nikita Kulikov [email protected]
Last Intel CI: http://intel-ci.intel.com/eec13fa7-5f87-f137-8390-a4bf010d0e2e
Is the primary goal of additions to have necessary functionality from https://github.com/IntelPython/dpctl/blob/master/dpctl/apis/include/dpctl4pybind11.hpp added to our repo?
Would we want to then explore removing dpctl usage from setup scripts (ie https://github.com/intel/scikit-learn-intelex/blob/main/setup.py#L92-L105) or is it unrelated?
CI looks good, and checked build and test/example logs as well - seems to be running smoothly
Is the primary goal of additions to have necessary functionality from https://github.com/IntelPython/dpctl/blob/master/dpctl/apis/include/dpctl4pybind11.hpp added to our repo?
Would we want to then explore removing dpctl usage from setup scripts (ie https://github.com/intel/scikit-learn-intelex/blob/main/setup.py#L92-L105) or is it unrelated?
Thank you for the review! We are going to remove dpctl dependency. I have follow-up PR already https://github.com/intel/scikit-learn-intelex/pull/1685 Also updates for our build scripts will be done. I prefer to do it separately step-by-step.
@ethanglaser thank you for the review! Will check perf once again before merge.