scikit-learn-intelex
scikit-learn-intelex copied to clipboard
intel
KMeans out of preview namespace
Before we merge this, I want to merge master into this branch and rerun CI, not just resolve conflicts. I will review this once it is brought up to date. I've been monkeying around with sklearnex CI a fair bit since the last commit, and want to see how it performs.
First task will get a green public CI, second step will be to comment out all kmeans-related deselected tests (including GPU) and see what we can reactivate
Note, I will delay this because there are some changes which need to be made first, and this will be useless at the moment.
I am glad that the BaseKMeans object has been removed, its really unnecessary. There is a lot of work to be done, it may be good to reference the current version of KMeans in preview to match n_jobs changes etc. There is some work that needs to be done before this is pulled out of preview. @md-shafiul-alam please message me if you have any questions.
The PR is relying on daal4py still, last commit as evidence, likely due to the daal_check_version. This needs to be sorted out first. This can change test coverage and performance, and will likely need be retested/re-benchmarked.
Moved the changes to https://github.com/intel/scikit-learn-intelex/pull/1770