scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

Integrating OneDAL primitives for `LogisticRegression`

Open avolkov-intel opened this issue 1 year ago • 7 comments

Description

Add scikit-learn-intelex interface for oneDAL algorithm objective_function

  • Defined new class LogisticLoss (defined in onedal/objective_function/objective_function.py). Its interface is almost alligned to LinearModelLoss class from stock scikit-learn https://github.com/scikit-learn/scikit-learn/blob/7db5b6a98ac6ad0976a3364966e214926ca8098a/sklearn/linear_model/_linear_loss.py#L9
  • Defined functions loss, gradient, loss_gradient, gradient_hessian, gradient_hessian_product
  • Covered new functionality with tests

avolkov-intel avatar May 04 '23 16:05 avolkov-intel

I really don't understand which api are your implementing here? in vanilla scikit-learn we already have API for log_loss https://scikit-learn.org/stable/modules/generated/sklearn.metrics.log_loss.html . I think it's worth following this API

samir-nasibli avatar May 04 '23 18:05 samir-nasibli

I really don't understand which api are your implementing here? in vanilla scikit-learn we already have API for log_loss https://scikit-learn.org/stable/modules/generated/sklearn.metrics.log_loss.html . I think it's worth following this API

I implement the API for LinearModelLoss class. https://github.com/scikit-learn/scikit-learn/blob/7db5b6a98ac6ad0976a3364966e214926ca8098a/sklearn/linear_model/_linear_loss.py#L9 This class is used internally by scikit-learn LogisticRegression

avolkov-intel avatar May 04 '23 21:05 avolkov-intel

@KulikovNikita @Alexsandruss could you review the code, please?

avolkov-intel avatar May 09 '23 09:05 avolkov-intel

/intelci: run

Alexsandruss avatar May 12 '23 08:05 Alexsandruss

/intelci: run

samir-nasibli avatar May 30 '23 09:05 samir-nasibli

Please rebase and run intel CI if it is required

samir-nasibli avatar May 30 '23 09:05 samir-nasibli

/intelci: run

avolkov-intel avatar May 30 '23 11:05 avolkov-intel

Can reopen if progress continues

ethanglaser avatar Mar 25 '24 20:03 ethanglaser