scikit-learn-intelex icon indicating copy to clipboard operation
scikit-learn-intelex copied to clipboard

Wrong Global Patching Commands in Documentation Homepage

Open mamei16 opened this issue 3 years ago • 5 comments
trafficstars

In both the documentation homepage and the global patching page it is written that the command to install the global patch is
python sklearnex.glob patch_sklearn.
However, this leads to the error python: can't open file 'sklearnex.glob': [Errno 2] No such file or directory. The correct command includes the command line option -m, i.e.
python -m sklearnex.glob patch_sklearn
I'm aware that this isn't a huge issue, but it has irked me since I discovered it two months ago.

mamei16 avatar May 10 '22 18:05 mamei16

Just here to say you saved my time :)

Alexdruso avatar May 21 '22 16:05 Alexdruso

Just here to say you saved my time :)

I was already thinking I wasted my time writing this issue, since none of the developers seem to care, but I'm happy it was at least helpful to somebody (:

mamei16 avatar May 21 '22 18:05 mamei16

HI @mamei16 Thanks a lot for pointing this out. I apologize for the delay in reply. I will create PR with the fix ASAP

PivovarA avatar May 23 '22 09:05 PivovarA

Hi @mamei16 Once again, thank you very much for pointing out the inaccuracy in our documentation. I created a PR with a fix

PivovarA avatar May 23 '22 09:05 PivovarA

Thank you for fixing it @PivovarA!

mamei16 avatar May 23 '22 15:05 mamei16