rohd icon indicating copy to clipboard operation
rohd copied to clipboard

More complete support for signed operations

Open mkorbel1 opened this issue 2 years ago • 3 comments

Motivation

Right now most operations in ROHD are unsigned. Less than, greater than, etc. would be a lot more convenient with some built in signed support.

Desired solution

Allow operations to be performed using signed or unsigned math optionally.

Alternatives considered

Letting users do their own signed math is unnecessary overhead.

mkorbel1 avatar Jan 14 '22 16:01 mkorbel1

Needs extensive testing as well, obviously

mkorbel1 avatar Mar 30 '22 16:03 mkorbel1

This also needs to consider things like toInt and toBigInt for LogicValue. Currently, if you have a 64-bit LogicValue, then the resulting toInt is signed, but if it's less then that it won't be signed because upper bits are zero. A consistent solution should be provided for all sign-related features, including these functions.

mkorbel1 avatar Jun 08 '22 23:06 mkorbel1

I imagine this is a pre-requisite to https://github.com/intel/rohd/issues/470

samimia-swks avatar Feb 29 '24 17:02 samimia-swks