rohd
rohd copied to clipboard
[FIX-issue#99] Allowing negative logic index values
Issue #99
- Now one can use negative values in indices for indexing or subset slicing.
- This effect is applied on
BusSubset
that is used byLogic slice()
- Indirectly this effect is also passed to function that uses
slice()
likeoperator[]
(indexing operator) andgetRange()
-
getRange()
Exception handling are redundant as it is handled byBusSubset()
contructor withinslice()
Just needs unit testing and documentation! Great start!
Thanks Max!! Will do it asap.
Just needs unit testing and documentation! Great start!
Made Changes as requested!
PR #174 is adding a bunch more lint checks, which will probably flag some new issues for you if you get in after that (when you pull the changes in). I'll wait a little bit to give you an opportunity to beat the PR in, but in the next day or two it will go in and then you'll have a little clean-up to do.
Thanks!