rohd icon indicating copy to clipboard operation
rohd copied to clipboard

[FIX-issue#99] Allowing negative logic index values

Open RPG-coder-intc opened this issue 2 years ago • 3 comments

Issue #99

  • Now one can use negative values in indices for indexing or subset slicing.
  • This effect is applied on BusSubset that is used by Logic slice()
  • Indirectly this effect is also passed to function that uses slice() like operator[] (indexing operator) and getRange()

RPG-coder-intc avatar Aug 26 '22 00:08 RPG-coder-intc

  • getRange() Exception handling are redundant as it is handled by BusSubset() contructor within slice()

RPG-coder-intc avatar Aug 26 '22 00:08 RPG-coder-intc

Just needs unit testing and documentation! Great start!

Thanks Max!! Will do it asap.

RPG-coder-intc avatar Aug 26 '22 19:08 RPG-coder-intc

Just needs unit testing and documentation! Great start!

Made Changes as requested!

RPG-coder-intc avatar Sep 02 '22 14:09 RPG-coder-intc

PR #174 is adding a bunch more lint checks, which will probably flag some new issues for you if you get in after that (when you pull the changes in). I'll wait a little bit to give you an opportunity to beat the PR in, but in the next day or two it will go in and then you'll have a little clean-up to do.

mkorbel1 avatar Oct 06 '22 18:10 mkorbel1

Thanks!

RPG-coder-intc avatar Oct 12 '22 16:10 RPG-coder-intc