rohd icon indicating copy to clipboard operation
rohd copied to clipboard

Custom definition names of `Module`s are not sanitized

Open mkorbel1 opened this issue 2 years ago • 0 comments

Describe the bug

It is possible to specify a definitionName that is not sanitary (as sanitized by Sanitizer), which means you can generate invalid SystemVerilog.

To Reproduce

Define a module with an unsanitary definitionName passed to Module's constructor.

Expected behavior

ROHD sanitizes the definition name so that it generates valid SystemVerilog.

Actual behavior

The unsanitary definition name is included directly in the generated SystemVerilog.

Additional context
Sanitization may as well occur directly within the constructor.

mkorbel1 avatar Jul 26 '22 17:07 mkorbel1