pcm icon indicating copy to clipboard operation
pcm copied to clipboard

Include-what-you-use changes and #include section reorganization

Open nealsid opened this issue 2 years ago • 4 comments

This is an initial run of IWYU over PCM sources, but isn't ready for review - just checking builds on platforms I don't have installed (FreeBSD, Windows)

nealsid avatar Sep 29 '22 21:09 nealsid

This is ready for review now if someone is able to take a look. I'm not sure why the macOS build is failing, but it seems unrelated and builds fine on my machine. Thank you!

nealsid avatar Sep 30 '22 22:09 nealsid

Thank you for accepting this contribution - it is always a team effort by multiple people. Unfortunately I have some travel this week so my time to update the change will limited and I will better know my schedule next week.

Again, many thanks for accepting this.

nealsid avatar Oct 05 '22 11:10 nealsid

Thank you for accepting this contribution - it is always a team effort by multiple people. Unfortunately I have some travel this week so my time to update the change will limited and I will better know my schedule next week.

Again, many thanks for accepting this.

Also, I meant to address if anyone thought running IWYU as a regular process should be considered. In my experience it has a few false positives (e.g., the reason forward decls are in a separate namespace block is that IWYU doesn't detect them if they are not) that would make it not worthwhile. It's probably better just to run it at regular intervals rather than keep it president in the automation. Thanks!

nealsid avatar Oct 05 '22 11:10 nealsid

Hey there, I unfortunately got a little sidetracked for a few months with moving and some non-project related tasks, but could definitely still update this and resubmit it. Need to get my VMs set up again so it may be a couple of weeks.

nealsid avatar Mar 22 '23 17:03 nealsid