llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Published 20 hours ago • verified publisher icon intel

[SYCL] Add some trivial util functions for half type.

Open jinge90 opened this issue 2 years ago • 1 comments

Signed-off-by: jinge90 [email protected]

jinge90 avatar Sep 02 '22 02:09 jinge90

/verify with https://github.com/intel/llvm-test-suite/pull/1250

jinge90 avatar Sep 19 '22 07:09 jinge90

/verify with https://github.com/intel/llvm-test-suite/pull/1250

jinge90 avatar Oct 03 '22 04:10 jinge90

Hi, @xtian-github , @zettai-reido and @intel/llvm-reviewers-runtime Could you take a look at this PR? Thanks very much.

jinge90 avatar Oct 03 '22 13:10 jinge90

Hi, @jinge90 Since the functions are in public namespace could you please clarify if we have an extension document covering them? If not, shouldn't we add/update existing one? Could you please add more details to the PR summary?

romanovvlad avatar Oct 04 '22 07:10 romanovvlad

/verify with https://github.com/intel/llvm-test-suite/pull/1250

jinge90 avatar Oct 11 '22 07:10 jinge90

Hi, @pvchupin Could you take a look at this PR?

Thanks very much.

jinge90 avatar Oct 17 '22 07:10 jinge90

Hi, @pvchupin Kind ping.

jinge90 avatar Oct 20 '22 07:10 jinge90

@jinge90, please address @romanovvlad comments. And please get @intel/llvm-reviewers-runtime approval.

pvchupin avatar Oct 20 '22 16:10 pvchupin

Hi, @romanovvlad As we discussed, we can proceed with this PR and I will submit a new PR to update the doc, is it OK?

@intel/llvm-reviewers-runtime Could you help review this PR?

Thanks very much.

jinge90 avatar Oct 21 '22 02:10 jinge90

Hi, @romanovvlad As we discussed, we can proceed with this PR and I will submit a new PR to update the doc, is it OK?

@intel/llvm-reviewers-runtime Could you help review this PR?

Thanks very much.

This is OK.

romanovvlad avatar Oct 21 '22 07:10 romanovvlad

Could you please add more details to the PR summary?

@jinge90, please do this.

pvchupin avatar Oct 21 '22 18:10 pvchupin

Could you please add more details to the PR summary?

@jinge90, please do this.

Done.

Thanks very much.

jinge90 avatar Oct 24 '22 01:10 jinge90

Hi, @intel/llvm-reviewers-runtime and @sergey-semenov Could you take a look at this PR?

Thanks very much.

jinge90 avatar Oct 25 '22 01:10 jinge90

Hi, @intel/llvm-reviewers-runtime and @sergey-semenov Kind ping~

jinge90 avatar Oct 27 '22 06:10 jinge90