llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][ABI-break] Promote extended CG/handler members

Open sergey-semenov opened this issue 2 years ago • 1 comments

Several new members were added to CG/handler via the extended member workaround. This patch promotes them to actual fields of those classes now that the ABI can be broken.

sergey-semenov avatar Aug 10 '22 17:08 sergey-semenov

I'm planning to remove the extended member mechanism in a separate follow-up PR, just so it would be easier to recover it if we need to add new members to CG classes in the future.

sergey-semenov avatar Aug 10 '22 17:08 sergey-semenov

@smaslov-intel Could you please review?

sergey-semenov avatar Aug 16 '22 10:08 sergey-semenov

@steffenlarsen Could you please merge this one?

sergey-semenov avatar Aug 17 '22 10:08 sergey-semenov

Looks like this introduced a post-commit failure, looking into it

sergey-semenov avatar Aug 17 '22 12:08 sergey-semenov