llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[DevOps] Add devops/scripts/sycl-bisect.bash

Open dwoodwor-intel opened this issue 3 years ago • 3 comments

This is a utility for running git-bisect on sycl-like branches that may contain upstream LLVM commits in the bisect range. Its main feature is automatically merging these commits into a sycl-based branch before testing them, and supports conveniently testing commits by specifying a LIT test to run or a custom bash command.

dwoodwor-intel avatar Aug 05 '22 17:08 dwoodwor-intel

I've moved these into devops/scripts, but they still have references to buildbot/configure.py and buildbot/compile.py that should be updated when those scripts are also moved (probably with a fallback so that sycl-bisect can still be used on commits with the old script locations). How soon will that be?

dwoodwor-intel avatar Aug 08 '22 18:08 dwoodwor-intel

I've moved these into devops/scripts, but they still have references to buildbot/configure.py and buildbot/compile.py that should be updated when those scripts are also moved (probably with a fallback so that sycl-bisect can still be used on commits with the old script locations). How soon will that be?

I think this is the question for the Devops team (@intel/dpcpp-devops-reviewers?).

I suggest we move these scripts in two steps to ensure smooth transition:

  1. Create devops versions of these scripts in new location, update documentation with instructions to use new scripts and add a deprecation message to buildbot script.
  2. Remove buildbot directory.

I think there might be users of these scripts how need some time on updating the way we configure DPC++ compiler build.

One more note: I'm don't see much value in check.py and compile.py, which are simple wrappers for cmake. configure.py can also be replaced with cmake presets or cmake cache for old cmake versions (e.g. see clang project cmake cache files as example).

bader avatar Aug 09 '22 12:08 bader

I've removed the uses of the buildbot scripts and switched to building with cmake directly, so this should be more future-proof with the upcoming build script changes

dwoodwor-intel avatar Aug 09 '22 18:08 dwoodwor-intel