llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Investigate flaky assert tests for HIP

Open npmiller opened this issue 2 years ago • 0 comments

The following PR introduced an implementation of assert for HIP

  • https://github.com/intel/llvm/pull/6424

And the assert tests were re-enabled in:

  • https://github.com/intel/llvm-test-suite/pull/1083

Locally none of the tests were failing so we went ahead and merged the changes but later on in:

  • https://github.com/intel/llvm/pull/6519

One of the assert test failed in the CI.

This is likely similar to the issue for CUDA in https://github.com/intel/llvm/issues/6416 however for HIP the same workaround are not applicable because the HIP runtime is aborting before it reaches the PI plugin so the failure isn't with host output we control. In addition in the CI the test seems to be crashing so it's unclear if this is a garbled output.

npmiller avatar Aug 03 '22 10:08 npmiller