llvm
llvm copied to clipboard
intel
[SYCL][ABI Break] Remove "cl" namespace
As part of the change, also start using "inline namespace _V1" to allow possible future ABI-affecting changes.
SPIRV upstream change: https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/1564
Given how easy it is to get into a merge conflict and how many approvals are required (and hard to get quickly enough), I don't think it will ever be green...
@intel/llvm-gatekeepers , should we weaken the merge criteria here maybe?
Given how easy it is to get into a merge conflict and how many approvals are required (and hard to get quickly enough), I don't think it will ever be green...
@intel/llvm-gatekeepers , should we weaken the merge criteria here maybe?
If your changes only remove "cl", then you have pre-approval from ESIMD (no need for explicit approval here). Otherwise, please ping @intel/dpcpp-esimd-reviewers
If your changes only remove "cl", then you have pre-approval from ESIMD (no need for explicit approval here). Otherwise, please ping https://github.com/orgs/intel/teams/dpcpp-esimd-reviewers
They also contain corresponding changes in places where mangling matters, like ESIMDVerifier.cpp/LowerESIMD.cpp.
Failures on LLVM Test Suite precommit are expected and expected to pass in "verify with" testing. An exception is
Timed Out Tests (1):
SYCL :: HierPar/hier_par_basic.cpp
which is most likely unrelated. I'd argue that (pending Jenkins/llvm-test-suite) we should proceed with merging this. If, in an unlikely event, of the failure being real I'll address it post-commit.
Edit: Jenkins/precomit is clear. I believe this is as much ready for the merge as would ever be possible, despite missing some formal review approval statuses. @intel/llvm-gatekeepers would you agree to merge this in?