llvm
llvm copied to clipboard
[SYCL][Reduction] Remove atomic64 check for `float` reductions
This patch
-
removes the check on
aspect::atomic64
for reductions using atomic operations of single precision floating-point values. This solves https://github.com/intel/llvm/issues/6054. However, it's not strictly necessary since also https://github.com/intel/llvm/pull/6429 solves it. -
adds the possibility of using
min
andmax
atomic operations for reductions ofdouble
values.
@aelovikov-intel - can you please review this patch as the only active developer of reduction these days?
@v-klochkov do we require to run any performance tests before commit?
Tag @steffenlarsen , in case you'd like to have a look as well.
Thanks for your reviews, @steffenlarsen @aelovikov-intel!
I rebased this PR onto the last refactoring of reductions, it should be fine. The unexpectedly passed test is enabled in https://github.com/intel/llvm-test-suite/pull/1097.
Thanks!