llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][Reduction] Remove atomic64 check for `float` reductions

Open pgorlani opened this issue 2 years ago • 4 comments

This patch

  1. removes the check on aspect::atomic64 for reductions using atomic operations of single precision floating-point values. This solves https://github.com/intel/llvm/issues/6054. However, it's not strictly necessary since also https://github.com/intel/llvm/pull/6429 solves it.

  2. adds the possibility of using min and max atomic operations for reductions of double values.

pgorlani avatar Jul 13 '22 15:07 pgorlani

@aelovikov-intel - can you please review this patch as the only active developer of reduction these days?

v-klochkov avatar Jul 22 '22 19:07 v-klochkov

@v-klochkov do we require to run any performance tests before commit?

aelovikov-intel avatar Jul 22 '22 20:07 aelovikov-intel

Tag @steffenlarsen , in case you'd like to have a look as well.

aelovikov-intel avatar Jul 25 '22 20:07 aelovikov-intel

Thanks for your reviews, @steffenlarsen @aelovikov-intel!

I rebased this PR onto the last refactoring of reductions, it should be fine. The unexpectedly passed test is enabled in https://github.com/intel/llvm-test-suite/pull/1097.

pgorlani avatar Jul 29 '22 10:07 pgorlani

Thanks!

aelovikov-intel avatar Aug 12 '22 18:08 aelovikov-intel