llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][NFC] Remove redundant __imf_fsigm* declarations

Open jinge90 opened this issue 1 month ago • 1 comments

We have declared __imf_fsigm* in https://github.com/intel/llvm/pull/20873/files#diff-8da594ced8852cd2e62e9d1fcd013ca0b2256b88b3745b30a239bb01aa7b2011R251 So, the declarations at the begining is redundant, just remove them.

jinge90 avatar Dec 11 '25 04:12 jinge90

We have declared __imf_fsigm* in https://github.com/intel/llvm/pull/20873/files#diff-8da594ced8852cd2e62e9d1fcd013ca0b2256b88b3745b30a239bb01aa7b2011R251 So, the declarations at the begining is redundant, just remove them.

I suggest we keep the first declaration and remove the second instead. It keeps sigmoid declarations aligned with the rest of the declarations.

bader avatar Dec 11 '25 04:12 bader

Hi, @bader I cleaned up sycl/builtins.hpp to remove all duplicate imf function declarations and also aligned the declaration style in imf headers with numeric team's. Could you help review? Thanks very much.

jinge90 avatar Dec 18 '25 01:12 jinge90