llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[Coverity] Potentially throwing call in an implicitly `noexcept` destructor

Open AlexeySachkov opened this issue 1 month ago • 1 comments

Reported as CID 535426, you can access the Coverity scan results here: https://scan.coverity.com/projects/intel-llvm?tab=overview

https://github.com/intel/llvm/blob/b1528119119af75cc5403d082f43aa6cd7f47871/sycl/source/detail/adapter_impl.hpp#L295-L300

All destructors are implicitly noexcept and Adapter->call may throw. I understand that there is not much we can do with respect to nicely reporting it without spending unreasonable amount of resources on this edge case (relatively speaking).

In any case I'm submitting this tracker to highlight the reported issue so that we decide on a resolution - if we decide not to fix it, we probably need to add a comment to the code to simplify Coverity issues analysis going forward.

AlexeySachkov avatar Nov 20 '25 16:11 AlexeySachkov

Current trunk: https://github.com/intel/llvm/blob/111ea29dd0659e33429e649e799dc04c4ffb5658/sycl/source/detail/adapter_impl.hpp#L295-L304

Looks https://github.com/intel/llvm/pull/20614 has just addressed it.

aelovikov-intel avatar Nov 21 '25 22:11 aelovikov-intel