llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][NFC] Extract specialization constant's processing from sycl-post-link to SYCLPostLink library.

Open maksimsab opened this issue 7 months ago • 1 comments

This change allows later reuse of specialization constant's processing in the New Offloading Model and sycl-jit.

maksimsab avatar Jun 17 '25 12:06 maksimsab

The interface of a functionhandleSpecializationConstants is controversial. It allows to invoke the function in the following manner if you don't need to generate new modules with spec constants replaced by default values:

SmallVector<ModuleDesc> MDs;
Modified |= handleSpecializationConstants(MDs, Mode);

If you have a better alternative for the function's interface let me know.

maksimsab avatar Jun 17 '25 12:06 maksimsab

Hi @intel/dpcpp-tools-reviewers

Could, please, someone take a look at this PR?

maksimsab avatar Sep 30 '25 15:09 maksimsab

@maarquitos14 Yes, we have plenty of sycl-post-link's testing. Later this testing should be migrated for New Offloading Model's tools.

maksimsab avatar Oct 06 '25 14:10 maksimsab

@intel/llvm-gatekeepers please consider merging

github-actions[bot] avatar Oct 06 '25 16:10 github-actions[bot]

@intel/llvm-gatekeepers Can we merge that please?

maksimsab avatar Oct 09 '25 14:10 maksimsab