llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[CI] Remove workarounds

Open KornevNikita opened this issue 7 months ago • 3 comments

devops_ref and cts_exclude_ref were used as workaronds to launch sycl-rel-nightly with the sycl-rel branch using the regular sycl branch. Now we run sycl-rel-nightly using the sycl-rel branch, so there is no need to keep these workarounds.

KornevNikita avatar Jun 17 '25 10:06 KornevNikita

Test run - https://github.com/intel/llvm/actions/runs/15685104960 All failures are known.

KornevNikita avatar Jun 17 '25 10:06 KornevNikita

BTW I guess this arg may also be eliminated (or at least changed to required: False): https://github.com/intel/llvm/blob/9830842c250bd64f0c4d0415abe0ccfba38b7461/.github/workflows/sycl-nightly.yml#L125 Now it's expected to always be github.sha, so we probably can painlessly drop it. @intel/dpcpp-devops-reviewers should we?

KornevNikita avatar Jun 17 '25 10:06 KornevNikita

BTW I guess this arg may also be eliminated (or at least changed to required: False):

https://github.com/intel/llvm/blob/9830842c250bd64f0c4d0415abe0ccfba38b7461/.github/workflows/sycl-nightly.yml#L125

Now it's expected to always be github.sha, so we probably can painlessly drop it. @intel/dpcpp-devops-reviewers should we?

Was it like that before the release CI changes, or did you have to add it? If you added, then feel free to drop.

aelovikov-intel avatar Jun 17 '25 14:06 aelovikov-intel

BTW I guess this arg may also be eliminated (or at least changed to required: False): https://github.com/intel/llvm/blob/9830842c250bd64f0c4d0415abe0ccfba38b7461/.github/workflows/sycl-nightly.yml#L125

Now it's expected to always be github.sha, so we probably can painlessly drop it. @intel/dpcpp-devops-reviewers should we?

Was it like that before the release CI changes, or did you have to add it? If you added, then feel free to drop.

Nope, looks like it was there before my change, I just renamed this input. So this is ready then.

KornevNikita avatar Jun 18 '25 08:06 KornevNikita

@aelovikov-intel could you please take a look? Due to schedule in sycl-rel-nightly we're still running this workflow on sycl, so we're getting two launches now. image

KornevNikita avatar Jun 24 '25 09:06 KornevNikita