intel
[SYCL] Fix 2D slicepitch info
Make slicePitch equal to image size and numSlices 1 for a 2D image.
This was incorrect but wasn't failing as many backends ignore Pitch[1] for a 2D image.
I could potentially make a unittest that checks whether a valid slice pitch is passed to the backend. The slice pitch is not exposed to the user for 2D images so the test would need to look at a backend SYCL_UR_TRACE.
I could potentially make a unittest that checks whether a valid slice pitch is passed to the backend. The slice pitch is not exposed to the user for 2D images so the test would need to look at a backend
SYCL_UR_TRACE.
unittest works for me! Thanks!
I've added a test in the E2E tests. There weren't any unittests using SYCL_UR_TRACE as this test does, and only a handful of tests in test so I though test-e2e was the most natural place for these.
@hdelan The failure is related, you need to add UNSUPPORTED-TRACKER or UNSUPPORTED-INTENDED to sycl/test-e2e/Basic/image/image_trace.cpp, grep the source for examples of exactly what to do.
@hdelan The failure is related, you need to add
UNSUPPORTED-INFOorUNSUPPORTED-INTENDEDto sycl/test-e2e/Basic/image/image_trace.cpp, grep the source for examples of exactly what to do.
And this is the reason why simply saying "failure is unrelated" without even copying the failing test name into the comment is wrong.
And this is the reason why simply saying "failure is unrelated" without even copying the failing test name into the comment is wrong.
I do it too sometimes :(, I'll try to be better both myself and checking for it before merging :)
@hdelan Please don't do 9 commits after approval without asking for it again. I'm happy to review as many times as needed.
@hdelan Please don't do 9 commits after approval without asking for it again. I'm happy to review as many times as needed.
Apologies @maarquitos14 .