[DeviceSanitizer][NFC] Add comments for initialization of LaunchInfo.Data.

Open haonanya1 opened this issue 7 months ago • 5 comments

AsanInterceptor::prepareLaunch has this call, which aligns with msan and tsan.

Jun 11 '25 06:06 haonanya1

Found the issue when investigate test failure in opencl cpu runtime.

Jun 11 '25 06:06 haonanya1

@intel/llvm-gatekeepers, pr is ready to merge. Thank you!

Jun 12 '25 01:06 haonanya1

It's better to add comments if it's necessary.

Jun 12 '25 01:06 zhaomaosu

When the kernel is filtered, it's still possible that LaunchInfo is used in kernel code, so the "syncToDevice" here will give it the default value.

To make this PR meaningful, could you help to add a comment to tip others not remove this line?

Jun 12 '25 01:06 AllanZyne

It's better to add comments if it's necessary.

I agree. If this is necessary, then the code should be commented for its necessity to avoid such problem.

Jun 12 '25 02:06 yingcong-wu