llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[sycl-rel] Cherry-pick sanitizer patches

Open KornevNikita opened this issue 6 months ago • 8 comments

Cherry-pick commits that reached the internal branch between intel/llvm cutoff and release branch pulldown.

KornevNikita avatar Jun 10 '25 11:06 KornevNikita

Can we get some inputs about the test failures seen here?

Thanks

asudarsa avatar Jun 11 '25 14:06 asudarsa

I retried the UR jobs and they are green now.

kbenzie avatar Jun 11 '25 15:06 kbenzie

I retried the UR jobs and they are green now.

Thanks @kbenzie. Can anyone comment on the other failures? Thanks

asudarsa avatar Jun 11 '25 15:06 asudarsa

I retried the UR jobs and they are green now.

Thanks @kbenzie. Can anyone comment on the other failures? Thanks

Failures are unrelated, the pre-commit on this branch is broken. Will be tested separately, I will provide a link a bit later.

KornevNikita avatar Jun 11 '25 15:06 KornevNikita

Ignore the pre-commit, it's broken. The actual test run - https://github.com/intel/llvm/actions/runs/15631542807 @bader take a look please.

KornevNikita avatar Jun 13 '25 11:06 KornevNikita

@AlexeySachkov, does it make sense to request code owners review for cherry-picks to the release branch? All these patches were reviewed when being committed to the sycl branch.

bader avatar Jun 13 '25 18:06 bader

@bader

Since we're (not the authors of original commits) cherry-picking these patches ourselves, we may cherry-pick something excessive (like this compiler-rt patch), so it's good to have someone double-checking it (though it slows down the process).

I believe in the future we'll update the process so that authors cherry-pick their patches themselves, maybe then we can update the protection rules to not require an approval.

KornevNikita avatar Jun 16 '25 08:06 KornevNikita

@bader done

KornevNikita avatar Jun 17 '25 09:06 KornevNikita