intel
[SYCL][NativeCPU] Support native_cpu in llvm::Triple.
The initial design of NativeCPU limited it to Clang for ease of maintenance, but upcoming changes will require knowledge of NativeCPU in the LLVM parts, which changes what is easiest to maintain.
The remaining clang-format errors in Triple.h and Triple.cpp should be ignored, these changes are to LLVM code and the code is formatted according to the rest of these files.
Rebased to resolve a conflict with the pulldown, the previous comment on code formatting will still apply, this is intentionally not clang-formatted because it follows how LLVM upstream formats that file.
Updated to address the TODO in prepare-builtins.cpp and to pull in the latest changes from the sycl branch, no other changes.
Updated to address the TODO in
prepare-builtins.cpp
That was wrong, that needs to be in the next patch. Apologies for the noise, it gets difficult to juggle patch sets, taken out again and reverted to the earlier version (but still updated to a newer commit on the sycl branch).
Updated to pull in the latest changes from the sycl branch to resolve a conflict with another PR that has been merged, no other changes.
Please re-review @asudarsa @intel/dpcpp-tools-reviewers, it's been almost three weeks since I updated to address and respond to the feedback and it's just been complete silence since then. This is holding up other PRs. If I need to make more changes I'd like to know what I need to do.
sorry for the delay
Thanks, much appreciated. Policy-wise I'm not sure whether this is now good to be merged. @asudarsa reviewed on behalf of @intel/dpcpp-tools-reviewers, you've now approved it on behalf of @intel/dpcpp-tools-reviewers, but GitHub still shows it as needing approval from @asudarsa separately too which I had not expected. If this is good to merge, could you do so? If this is not good to merge, I will wait.
btw feel free to ping the reviewer group when you are looking for a review, for my PRs i ping once a day usually and after 3 days i email someone, you dont need to wait weeks!
code formatting ci failure looks dumb, change matches upstream code
