llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[Joint Matrix] Enable different accumulator and output types in spirv. Add tests to cover bfloat16 and half floating-point sizes.

Open ggojska opened this issue 9 months ago • 1 comments

Updated matrix_compare and matrix_multiply_ref functions to better match bfloat16 calculations on device.

ggojska avatar Mar 18 '25 12:03 ggojska

@ggojska , please, resolve conflicts.

YuriPlyakhin avatar Jun 02 '25 16:06 YuriPlyakhin

@intel/llvm-gatekeepers Are those test fails in pre-commit know issue or is it on my side?

ggojska avatar Jul 01 '25 10:07 ggojska

@YuriPlyakhin, can you approve the requested changes if you are happy with the changes made?

dkhaldi avatar Jul 08 '25 16:07 dkhaldi

@intel/llvm-reviewers-runtime, please help review the non matrix parts

dkhaldi avatar Jul 08 '25 18:07 dkhaldi

@intel/llvm-gatekeepers, this PR is ready to be merged.

dkhaldi avatar Jul 08 '25 19:07 dkhaldi

@intel/llvm-gatekeepers, this PR is ready to be merged.

Need @YuriPlyakhin to unblock.

aelovikov-intel avatar Jul 08 '25 19:07 aelovikov-intel

This commit will be authored by [email protected].

@ggojska you need to make your e-mail public on Github, I think.

aelovikov-intel avatar Jul 08 '25 20:07 aelovikov-intel

@aelovikov-intel it should be public now

ggojska avatar Jul 09 '25 10:07 ggojska