llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Remove -full-main-file-name and -fsycl-use-main-file-name options.

Open zahiraam opened this issue 1 year ago • 1 comments

These two options were implemented to solve two issues (missing checksum for the main file on Windows and host compilation DICompileUnit pointing to a temporary file instead of the original source file). The introduction of the -include-footer solves these issues. These options can now be removed.

zahiraam avatar Aug 14 '24 14:08 zahiraam

@stevemerr I have done some local test including the one I mentioned to you offline and it's passing. I think it would be nice to have you test full DBG testing to see if this change works for you. Thanks.

zahiraam avatar Aug 15 '24 13:08 zahiraam

@premanandrao Can you please review this? Thanks.

zahiraam avatar Sep 03 '24 12:09 zahiraam

@intel/llvm-gatekeepers Can this be merged please? Thanks.

zahiraam avatar Sep 04 '24 12:09 zahiraam