llvm icon indicating copy to clipboard operation
llvm copied to clipboard
verified publisher icon intel

[SYCL][NFC] Detach unit-tests naming from UR

Open AlexeySachkov opened this issue 1 year ago • 3 comments

This is a follow-up from #14145. Our unit tests have mock classes corresponding to device images and other entries our compiler generates. They are all named using Ur prefix, but they have nothing to do with Unified Runtime, they are part of our compiler interface.

This patch renames associated files and classes so they do not refer to Ur anymore. This is a mechanical find-and-replace change.

AlexeySachkov avatar Jul 28 '24 09:07 AlexeySachkov

This PR will conflict with #14816. I have no strict preference about which one goes first, but I think that if we merge this one first, then I will have less conflicts to resolve.

AlexeySachkov avatar Jul 28 '24 10:07 AlexeySachkov

then I will have left conflicts to resolve.

Is that s/left/less/ ?

aelovikov-intel avatar Jul 29 '24 15:07 aelovikov-intel

then I will have left conflicts to resolve.

Is that s/left/less/ ?

Yes

AlexeySachkov avatar Jul 29 '24 15:07 AlexeySachkov

3eafbcb1590f8c31017d47e52d59ed54944f380e - a very small change which I missed earlier because virtual functions unit-tests were disabled at the time.

AlexeySachkov avatar Oct 30 '24 15:10 AlexeySachkov

I've verified locally that build and unit-tests still pass after merge with sycl branch, so I will proceed with this PR.

AlexeySachkov avatar Nov 05 '24 09:11 AlexeySachkov