llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Don't throw in `device_impl::has`

Open aelovikov-intel opened this issue 1 year ago • 2 comments

  1. It isn't right
  2. We need this change to get rid of deprecated sycl::exception::get_cl_code

aelovikov-intel avatar Jun 28 '24 17:06 aelovikov-intel

  1. It isn't right

Please, don't write description like that. Instead put an answer to "why it's not right?". Our contribution guide has a link to the article with good hints on writing good commit message - https://cbea.ms/git-commit/#why-not-how.

bader avatar Jun 28 '24 17:06 bader

I'd be happy to have a discussion with somebody who can explain to me how it might make even a tiniest bit of sense for a "has" method to throw an exception. Until then, "it isn't right" is pretty much how I see it.

aelovikov-intel avatar Jun 28 '24 17:06 aelovikov-intel