llvm
llvm copied to clipboard
[SYCL] Don't throw in `device_impl::has`
- It isn't right
- We need this change to get rid of deprecated
sycl::exception::get_cl_code
- It isn't right
Please, don't write description like that. Instead put an answer to "why it's not right?". Our contribution guide has a link to the article with good hints on writing good commit message - https://cbea.ms/git-commit/#why-not-how.
I'd be happy to have a discussion with somebody who can explain to me how it might make even a tiniest bit of sense for a "has" method to throw an exception. Until then, "it isn't right" is pretty much how I see it.